Change ADU client update id to match service specification #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update-id reported by the ADU agent, as defined by the ADU service, is an escaped string, and has no need to be split into a separate struct with the individual components (provider, name, version). This change simplifies the ADU agent state generation by following this specification, as well as removes a bug-prone buffer manipulation from az_iot_adu_client.c.
ewertons
requested review from
CIPop,
danewalton,
ericwolz,
JoseSanchez7,
jspaith,
preethi826 and
vaavva
as code owners
danewalton
reviewed
Sep 8, 2022
danewalton
approved these changes
Sep 8, 2022
vaavva
approved these changes
Sep 8, 2022
|
/check-enforcer reset |
ewertons
added a commit
to Azure/azure-iot-middleware-freertos
that referenced
this pull request
Sep 10, 2022
Please refer to Azure/azure-sdk-for-c#2331 for details.
ewertons
added a commit
to Azure/azure-iot-middleware-freertos
that referenced
this pull request
Sep 12, 2022
* Change ADU client update id to match service specification Please refer to Azure/azure-sdk-for-c#2331 for details. * Update submodule
ewertons
added a commit
to Azure-Samples/iot-middleware-freertos-samples
that referenced
this pull request
Sep 12, 2022
Change ADU client update id to match service specification Please refer to Azure/azure-sdk-for-c#2331 for details.
ewertons
added a commit
to Azure-Samples/iot-middleware-freertos-samples
that referenced
this pull request
Sep 12, 2022
Please refer to Azure/azure-sdk-for-c#2331 for details.
ewertons
added a commit
to Azure-Samples/iot-middleware-freertos-samples
that referenced
this pull request
Sep 12, 2022
* Change ADU client update id to match service specification Please refer to Azure/azure-sdk-for-c#2331 for details. * Code style fixes * Fix NXP and simulated examples * Code style fixes
danewalton
pushed a commit
to danewalton/azure-sdk-for-c
that referenced
this pull request
Sep 14, 2022
* Change ADU client update id to match service specification The update-id reported by the ADU agent, as defined by the ADU service, is an escaped string, and has no need to be split into a separate struct with the individual components (provider, name, version). This change simplifies the ADU agent state generation by following this specification, as well as removes a bug-prone buffer manipulation from az_iot_adu_client.c. * Fix code style * Remove left-over printfs * Address code review comments * Fix spacing
danewalton
pushed a commit
to danewalton/azure-sdk-for-c
that referenced
this pull request
Sep 14, 2022
* Change ADU client update id to match service specification The update-id reported by the ADU agent, as defined by the ADU service, is an escaped string, and has no need to be split into a separate struct with the individual components (provider, name, version). This change simplifies the ADU agent state generation by following this specification, as well as removes a bug-prone buffer manipulation from az_iot_adu_client.c. * Fix code style * Remove left-over printfs * Address code review comments * Fix spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update-id reported by the ADU agent, as defined by the ADU service, is an escaped string, and has no need to be split into a separate struct with the individual components (provider, name, version). This change simplifies the ADU agent state generation by following this specification, as well as removes a bug-prone buffer manipulation from az_iot_adu_client.c.